fix: handle dynamic multiple attribute on select#17306
Draft
Uzair-Ahmed-Shah wants to merge 5 commits intosveltejs:mainfrom
Draft
fix: handle dynamic multiple attribute on select#17306Uzair-Ahmed-Shah wants to merge 5 commits intosveltejs:mainfrom
Uzair-Ahmed-Shah wants to merge 5 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: fb119fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17280 (edit: it does not)
This PR fixes an issue where the selected property of options in a
<select>element would not update correctly when the multiple attribute was toggled dynamically (e.g.,<select {multiple}>).The Problem
Previously, the runtime
MutationObserverin select.js only watched for changes to the value attribute. It ignored changes to the multiple attribute. Consequently, when multiple changed fromfalsetotrue(or vice versa), the selection logic was not re-evaluated, leading to inconsistent DOM states where options had selected attributes but selected properties set tofalse.Additionally, the compiler explicitly forbade using a dynamic multiple attribute with
bind:value, throwing an attribute_invalid_multiple error.The Solution
MutationObserverin packages/svelte/src/internal/client/dom/elements/bindings/select.js to include'multiple'in itsattributeFilter. This ensures the selection logic runs whenever the multiple attribute changes.bind:value.Tests
packages/svelte/tests/runtime-runes/samples/select-multiple-dynamic-attribute.multipleattribute and asserts thatselect.multipleandoption.selectedproperties update correctly.binding-select-multiple-dynamicwhich asserted the now-removed error.packages/svelte/tests/runtime-runespass.Checklist
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).pnpm testand lint the project withpnpm lint.