Skip to content

fix: preserve old dependencies when updating reaction inside fork#17579

Merged
Rich-Harris merged 1 commit intomainfrom
keep-reactions-after-fork
Jan 28, 2026
Merged

fix: preserve old dependencies when updating reaction inside fork#17579
Rich-Harris merged 1 commit intomainfrom
keep-reactions-after-fork

Conversation

@Rich-Harris
Copy link
Member

#17335 contains two separate fixes — this extracts one of them, so that they can be reviewed separately

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Co-authored-by: David Roizenman <hmnd@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2026

🦋 Changeset detected

Latest commit: 5fdb5ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@17579

@Rich-Harris
Copy link
Member Author

this LGTM — can't approve because it's 'my' PR but @hmnd did all the work. Merging

@Rich-Harris Rich-Harris merged commit 3608b3c into main Jan 28, 2026
17 of 18 checks passed
@Rich-Harris Rich-Harris deleted the keep-reactions-after-fork branch January 28, 2026 21:59
@github-actions github-actions bot mentioned this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant