[DON'T MERGE] wlr-workspaces implementation #2357
Conversation
include/wlr/types/wlr_workspace_v1.h
Outdated
| struct wlr_workspace_group_handle_v1 *group; | ||
|
|
||
| // request from the client | ||
| uint32_t pending, current; |
There was a problem hiding this comment.
pending_state, current_state better, I think, Or pending_data and current_data
|
wayland-protocols MR: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/40 |
| The different states that a workspace can have. | ||
| </description> | ||
|
|
||
| <entry name="active" value="0" summary="the workspace is active"/> |
There was a problem hiding this comment.
How about add some usefull states mentioned in https://github.com/swaywm/wlr-protocols/pull/35/files
?
There was a problem hiding this comment.
In the wayland-protocols PR here: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/40
I have added urgent and hidden. I'll also update this PR once it is approved upstream.
|
|
||
| wl_display_flush(display); | ||
|
|
||
| if (monitor != false) { |
add wlr-workspace header start wlr_workspace impl by copying from wlr_foreign_toplevel add more stubs workspace: implement output_enter/leave add create methods start with impl destroy finish impelmenttation of workspace-unstable implement wlr-workspace example small fixes to the example client fix names as requested in review
|
I have now updated the implementation to match the latest changes in the PR (so this is ready for review) |
|
Any updates here? |
PRs are waiting for a review. |
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/2357 |
4 participants
This is my work so far on implementing swaywm/wlr-protocols#35
I decided to first implement the protocol in its current form (with slight modifications as I saw fit), and I'd like feedback on them.
If it looks okay I will rename
wlrtoextand open a PR against wayland-protocols as well.The only notable change from the PR is that all synchronization is done at the workspace-manager level (both commit and done are moved there), although we could make them per workspace-group.
About the implementation, it should be very similar to foreign-toplevel-management, in almost all aspects. I am not 100% sure on the commit part (with pending, current & server_state).
If someone wants to test, I have added a wayfire plugin to support this protocol: WayfireWM/wayfire#647