Draft
Conversation
This was referenced Jun 30, 2025
CodSpeed Performance ReportMerging #10734 will not alter performanceComparing Summary
|
kdy1
commented
Jun 30, 2025
| op(self, &mut buf) | ||
| } | ||
|
|
||
| fn read_unicode_escape(&mut self) -> LexResult<Vec<Char>> { |
Member
Author
There was a problem hiding this comment.
cc @bvanjoi Do you think this change is correct?
Contributor
There was a problem hiding this comment.
If I understand correctly, this implementation appears incorrect. For read_unicode_escape('\u0041'), we expect the raw character sequence ['\\', 'u', '0', '0', '4', '1'] as output, not the decoded 'A' directly.
Member
Author
There was a problem hiding this comment.
Thank you! I think you are right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: