Skip to content

docs(es/minifier): Clarify semantic preservation policy - #12349

Merged
Donny/강동윤 (kdy1) merged 2 commits into
mainfrom
codex/minifier-semantic-policy
Sep 11, 2026
Merged

docs(es/minifier): Clarify semantic preservation policy#12349
Donny/강동윤 (kdy1) merged 2 commits into
mainfrom
codex/minifier-semantic-policy

Conversation

@kdy1

Copy link
Copy Markdown
Member

Description:

Clarify the minifier implementation and review policy to prioritize correctness for common usage, performance, and maintainable code. Do not require additional defensive logic solely for monkey-patched globals or built-ins, unusual arguments.length reassignment, direct-eval bindings, or dynamic name resolution in with.

Keep ordinary lexical shadowing, side effects, and exceptions within the supported assumptions in scope. Require reviewers to demonstrate an impact on common usage or an explicit support contract for mandatory fixes. Align execution-test guidance with this policy without authorizing hidden failures or blanket removal of existing handling or tests.

The policy change is limited to the minifier AGENTS.md; a required patch changeset is included. No runtime code or tests change.

Validation:

  • Passed: cargo fmt --all, git diff --check, cargo test -p swc_ecma_minifier, and minifier ./scripts/exec.sh.
  • The crate tests exited successfully but emitted missing terser module errors from a helper script.
  • cargo clippy --all --all-targets -- -D warnings failed on the existing unused noexec_mount_in function in crates/swc_native_addon/src/platform/unix.rs:117.

Related issue (if exists):

Motivated by the review discussions in #12343:

@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ae4cba3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T12:06:31.942057Z ae4cba3 PR opened
🔒 Security Review Completed 2026-09-11T12:07:01.314815Z ae4cba3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kdy1
Donny/강동윤 (kdy1) merged commit ff6a3c3 into main Sep 11, 2026
38 checks passed
@kdy1
Donny/강동윤 (kdy1) deleted the codex/minifier-semantic-policy branch September 11, 2026 12:11
@github-actions github-actions Bot added this to the Planned milestone Sep 11, 2026
@codspeed-hq

codspeed-hq Bot commented Sep 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 206 untouched benchmarks
⏩ 61 skipped benchmarks1


Comparing codex/minifier-semantic-policy (ae4cba3) with main (14bfa36)

Open in CodSpeed

Footnotes

  1. 61 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant