docs(es/minifier): Clarify semantic preservation policy - #12349
Conversation
🦋 Changeset detectedLatest commit: ae4cba3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merging this PR will not alter performance
Comparing Footnotes
|
Description:
Clarify the minifier implementation and review policy to prioritize correctness for common usage, performance, and maintainable code. Do not require additional defensive logic solely for monkey-patched globals or built-ins, unusual
arguments.lengthreassignment, direct-eval bindings, or dynamic name resolution inwith.Keep ordinary lexical shadowing, side effects, and exceptions within the supported assumptions in scope. Require reviewers to demonstrate an impact on common usage or an explicit support contract for mandatory fixes. Align execution-test guidance with this policy without authorizing hidden failures or blanket removal of existing handling or tests.
The policy change is limited to the minifier AGENTS.md; a required patch changeset is included. No runtime code or tests change.
Validation:
cargo fmt --all,git diff --check,cargo test -p swc_ecma_minifier, and minifier./scripts/exec.sh.tersermodule errors from a helper script.cargo clippy --all --all-targets -- -D warningsfailed on the existing unusednoexec_mount_infunction incrates/swc_native_addon/src/platform/unix.rs:117.Related issue (if exists):
Motivated by the review discussions in #12343: