Fixing figures in dark-mode #1113
Closed
martin-raden wants to merge 2 commits intoswcarpentry:mainfrom
Closed
Conversation
Updated image tags to include style attributes for better visibility.
Updated the image style for conflict diagram in the documentation.
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
Contributor
|
Hey @martin-raden - there is a mechanism for using light-version images in dark mode, by providing the same light-mode image as We acknowledge that this isn't easily findable or documented, so it's on our list to do, but this would be our preferred solution. As such, I'll close this PR as we'd prefer to have explicit image versions for each mode. This also means you can have your own custom images for each mode, and not a simple colour invert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
when switching to dark-mode (in different browsers, ie. MS Edge and Firefox) images are "inverted".
While this is fine for most, some images of your tutorial are getting less illustrating in my opinion:
The only fix I found was to counter the CSS-induced "color invertion" with a dedicated CSS-statement for images that are to be kept in original coloring also in dark mode, i.e. adding
style="filter:invert(0);"within the image's Markdown code.I changed the invertion for
Hope that helps.
Best,
Martin