-
-
Notifications
You must be signed in to change notification settings - Fork 1k
adding linux possible clear exception #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/shell-novice/compare/md-outputs..md-outputs-PR-1493 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-08-21 13:53:50 +0000 |
Investigating this. Please try to wrap text at 80 characters to help readability of source files. |
I'll wrap to 80 char as requested. Going forward we might want to consider semantic line breaks instead as they are more readable and accessible. |
|
## Clearing your terminal | ||
|
||
If your screen gets too cluttered, you can clear your terminal using the | ||
`clear` command. You can still access previous commands using <kbd>↑</kbd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`clear` command. You can still access previous commands using <kbd>↑</kbd> | |
`clear -x` command. You can still access previous commands using <kbd>↑</kbd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the -x
flag is needed here. The addition for some bash configurations is mentioned below and the unexplained flag so early in the lessons where they are learning about options may be more cognitive load and more confusing than beneficial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is better to move this after introducing manual pages? Would hesitate to remove that one can access previous commands - if one uses clear
and is no longer able to access previous commands this will cause confusion that likely raised the associated issue. As Bash and other shells are configurable, introducing that one may need to manage/check configurations and look up options in the documentation is helpful. There is a cognitive load, but pretending these situations will not occur is a disservice - instead we want to encourage a growth mindset that one can configure a shell to be more efficient for what they do. The line above introduces ls -F
, so showcasing options a little later may be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Happy for it to be included there with the -x
flag. Thanks for the point out that they learned using flags ahead of this statement!
In my experience, the clear
here is included so that instructors who use it by habit can mention it to learners rather than because learners really need it at this point. I'm happy to leave it here with the flag as is currently written.
are **files** in the current working directory. | ||
|
||
::::::::::::::::::::::::::::::::::::::::: callout | ||
::::::::::::::::::::::::::::::::::::::::: spoiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benson and I are wondering about why this section was made into a spoiler? Is it because this is too much information? Thank you for looking through this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my understanding, a callout is something that that all instructors should cover because it highlights an important point. A spoiler is optional material and in my experience clear
is something the learners don't have to learn at this point and so it is better left to the discretion of the instructor and thus placed in a spoiler. I don't even use clear
regularly in my practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should note, many of the older lessons have callouts might be better as spoilers throughout them since the spoiler capability is a relatively recent addition to the workbench. Before that feature, callouts were used somewhat inconsistently for optional content and important content.
I've been on the look out for them in my issues/PRs and noticed this one when I went to add the info about clear sometimes clearing the scrollback buffer.
Co-authored-by: Pariksheet Nanda <[email protected]>
fixes #1492
I added language that for some linux systems
clear
might also clear the scrollbuffer.I'd also recommend making this callout a spoiler instead since it is optional content instead of content that should be highlighted. I can switch this back if maintainers disagree.