Open
Conversation
Collaborator
|
@swift-ci test |
Collaborator
|
Seeing a build failure for the project it seems |
Member
Author
|
That's in swift-system it appears - what would you recommend here? |
Collaborator
|
@swift-ci test |
Collaborator
|
@czechboy0 We'll likely need to fix the dependency project (swift-system), in this case since we're building with swift 6 looks like we would probably need to add import Darwin.Machhttps://github.com/apple/swift-system/blob/1.6.3/Sources/System/MachPort.swift#L12C1-L12C19 That or we change the swift build version of this project to 5 for the time being |
Member
Author
|
@parkera would it make sense to add swift-syntax to the compat suite first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add Swift Configuration to the compat suite.
Acceptance Criteria
To be accepted into the Swift source compatibility test suite, a project must:
./project_precommit_checkscript runEnsure project meets all listed requirements before submitting a pull request.