Open
Conversation
Collaborator
Author
|
@swift-ci test |
hamishknight
approved these changes
Mar 3, 2026
Collaborator
hamishknight
left a comment
hamishknight
left a comment
There was a problem hiding this comment.
run_sk_stress_test changes LGTM, just one question
run_sk_stress_test
Outdated
| branch: str | ||
|
|
||
| def __init__(self, wrapper: str, stress_tester: str, swiftc: str, projects_path: str, branch: str, xfails_path: str): | ||
| def __init__(self, wrapper: str, stress_tester: str, swiftc: str, args: argparse.Namespace, branch: str, xfails_path: str): |
Collaborator
There was a problem hiding this comment.
Rather than passing the command-line arguments to StressTesterRunner, would it make more sense to load the projects up-front and pass those?
Collaborator
Author
There was a problem hiding this comment.
Good idea, updated 👍
Collaborator
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Users will be able to use
--projects-diror the--projectsflags with the various scripts, however the projects.json file has been removed in favor orprojects/Do not merge this upon approval as it will require some coordination