Swift Crypto: 3.12.3 -> 3.12.5 #83245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Swift Crypto 3.12.3 was missing several source files from the CMake build system resulting in build failures on Arm64 Windows. 3.12.4 contains fixes for this issue, bumping to that version now. That hit a bug in CMake, so bumping to 3.12.5.
etcwilde
force-pushed
the
ewilde/bump-swift-crypto-version
branch
from
8fb6504 to
fd701c1
Compare
etcwilde
changed the title
|
@swift-ci please smoke test |
|
I had to do a few more changes to get it to build locally. I also noticed that crypto brings its own version of ASN1, so I modified the build order a bit. See #83263. |
|
Closing in favor of #83263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Crypto 3.12.3 was missing several source files from the CMake build system resulting in build failures on Arm64 Windows. 3.12.5 contains fixes for this issue, bumping to that version now.