Add half-fourier basis - #7387
Merged
wthrowe merged 2 commits intoSep 1, 2026
Merged
Conversation
michaeldmurphy1
force-pushed
the
half_fourier_basis
branch
from
July 14, 2026 21:39
0972418 to
be47944
Compare
wthrowe
requested changes
Jul 24, 2026
Comment on lines
6
to
+9
| #include <cstddef> | ||
|
|
||
| #include <cmath> | ||
| #include <numbers> |
Comment on lines
6
to
+9
| #include <cstddef> | ||
|
|
||
| #include <cmath> | ||
| #include <numbers> |
michaeldmurphy1
force-pushed
the
half_fourier_basis
branch
from
July 24, 2026 20:56
be47944 to
848b45c
Compare
michaeldmurphy1
marked this pull request as draft
July 27, 2026 15:36
Contributor
Author
|
I walk to talk to Larry and Nils before this is merged |
Represending functions on a half-circle could be useful to Cartoon evolutions; in paticular for outer boundaries in GH where an angular basis could be more suitable to constraint-preserving BC Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
michaeldmurphy1
force-pushed
the
half_fourier_basis
branch
from
August 31, 2026 15:27
848b45c to
fb30197
Compare
michaeldmurphy1
marked this pull request as ready for review
August 31, 2026 15:27
Contributor
Author
|
Okay, I've convinced myself this is a useful thing to add to the code! |
wthrowe
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This packages the discrete sin/cos transformations (II) into one basis, which when needed will take a parity parameter (similar to ZernikeB1)
One motivation for this basis is for axially symmetric cartoon simulations, where having an angular basis for an outer boundary could be beneficial for GH constraint-preserving BC (though as of now, I have not seen improvements in my recent runs)
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com"
as the last line of the commit, depending on the agent.
Further comments