Add Lax-Friedrichs flux for the LDG system SecondOrderScalarWave - #7520
Merged
wthrowe merged 2 commits intoSep 4, 2026
Conversation
hen-w
force-pushed
the
ldg_scalar_wave_lf_flux_pr
branch
2 times, most recently
from
August 31, 2026 18:04
df23089 to
e28671b
Compare
hen-w
marked this pull request as ready for review
August 31, 2026 18:05
wthrowe
requested changes
Sep 2, 2026
Comment on lines
+1100
to
+1106
| for (const auto use_moving_mesh : { | ||
| false // , true | ||
| }) { | ||
| for (const auto dg_formulation : { | ||
| ::dg::Formulation:: | ||
| StrongInertial // , ::dg::Formulation::WeakInertial | ||
| }) { |
|
|
||
| Scalar<DataVector> packaged_psi{num_pts}; | ||
| tnsr::i<DataVector, Dim, Frame::Inertial> psi_times_normal{num_pts}; | ||
| const ScopedFpeState disable_fpes(false); |
Member
There was a problem hiding this comment.
If you need this for the isnan check, only do it for that check, not the function call. If the function is causing FPEs, that needs to be fixed.
| * Below, \f$n^i\f$ denotes the interior element's outward-directed unit face | ||
| * normal. \f$\{\{\Psi\}\}\f$ denotes the central average of \f$\Psi\f$ across | ||
| * the interface, and | ||
| * \f$[[\Psi]]=n^\text{int}\Psi^\text{int}+n^\text{ext}\Psi^\text{ext}\f$ |
Member
There was a problem hiding this comment.
What is the scalar quantity n^int?
| for (size_t d = 0; d < Dim; ++d) { | ||
| phi_boundary_correction->get(d) = | ||
| 0.5 * (psi_times_normal_int.get(d) + psi_times_normal_ext.get(d)) - | ||
| 0.5 * tau2_ * (get(psi_ext) - get(psi_int)); |
Member
There was a problem hiding this comment.
Something is wrong here. I don't understand your documentation math well enough to know what the correct expression would be.
Member
|
Squash and rebase. |
…corrections Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hen-w
force-pushed
the
ldg_scalar_wave_lf_flux_pr
branch
from
September 4, 2026 19:22
4a6d70f to
d143fec
Compare
wthrowe
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Generalize the boundary correction test helper to handle LDG boundary corrections. Add
LaxFriedrichsboundary correction for the LDG systemSecondOrderScalarWave.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: " as the last line of the
commit, e.g. "Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com".
Further comments