Fix compiling with gcc 15, nvcc 13 - #7521
Merged
Merged
Conversation
nilsvu
changed the title
nilsvu
force-pushed
the
upgrade_container
branch
from
September 1, 2026 07:16
1afd890 to
39339be
Compare
nilsdeppe
requested changes
Sep 4, 2026
nilsdeppe
left a comment
nilsdeppe
left a comment
Member
There was a problem hiding this comment.
Can you please factor this into several PRs? There are a number of additional changes that are clearly necessary for supporting newer compilers or fixing bugs found by them, but the name and description of the PR makes that not at all obvious.
Widen the boost odeint warning suppression from GCC 13 to GCC 13 and newer. Stop enabling `-Wdisabled-optimization`. GCC 15's new `ext-dce` pass declines to run on very large functions and reports that through this warning, which `-Werror` turns into a build failure. Nothing in the code is wrong, and raising the size limit would only move the threshold. Give the DataBox member function pointers explicit target types, which nvcc 13 needs to avoid naming these host-only functions while compiling for device. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The buffer is a `std::array`, so every slot holds a live object from construction. `emplace` constructed over those and `pop` destroyed them, so the array's destructor destroyed popped slots a second time. GCC 15 surfaces this as a double free in `Unit.Evolution.DG.InboxTags`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`libck` expects `CkRegisterMainModule`, but only a generated main module defines it, so executables without one, such as `ConvertComposeTable`, fail to link. Define it weakly; a real main module overrides it. It aborts rather than doing nothing, so an executable linked without its main module says so instead of hanging. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
We build with C++20, so the `__cplusplus < 201402L` branches are unreachable. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nilsvu
force-pushed
the
upgrade_container
branch
from
September 4, 2026 19:26
39339be to
6ea2c00
Compare
nilsvu
changed the title
Member
Author
|
Sure! I dropped the container upgrade; only pushed the gcc 15 and nvcc 13 fixes. |
nilsdeppe
approved these changes
Sep 4, 2026
Member
Author
|
Here's the container-upgrade follow-up: #7539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix issues to support GCC 15 and nvcc 13
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate."Co-Authored-By: " as the last line of the
commit, e.g. "Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com",
"Co-Authored-by: Codex noreply@openai.com", or
"Co-Authored-By: GitHub Copilot CLI noreply@microsoft.com".
Further comments