Add explicit value for csrf_protection.enabled when adding stateless_token_ids #1453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had the recipe adding stateless_token_ids. I thought that csrf_protection will be enabled by default. But
debug:config
showed me that csrf_protection.enabled is null by default.The current documentation does not explicitly mention that one should add
enable: true
when using the stateless_token_ids: https://symfony.com/doc/current/security/csrf.html#stateless-csrf-tokensSo I thought to add
enable: true
by default, to be coherent with the comment of the recipe:# Enable stateless CSRF protection for forms and logins/logouts
.I hope this is correct.