[DependencyInjection] Add mentions where to find configCache #20035
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carsonbot can someone review it? 🙏 |
|
@alexandre-daubois thx for suggestions :) |
OskarStark
reviewed
Jul 12, 2024
| @@ -500,7 +500,8 @@ serves at dumping the compiled container:: | |||
| The ``file_put_contents()`` function is not atomic. That could cause issues | |||
| in a production environment with multiple concurrent requests. Instead, use | |||
| the :ref:`dumpFile() method <filesystem-dumpfile>` from Symfony Filesystem | |||
| component or other methods provided by Symfony (e.g. ``$containerConfigCache->write()``) | |||
| component or other methods provided by Symfony (e.g. ``$containerConfigCache->write()`` | |||
| which is part of the :doc:`Config component </components/config>`) | |||
| which are atomic. | |||
There was a problem hiding this comment.
the atomic part relates to the method, not to the config component
There was a problem hiding this comment.
@OskarStark true, my point is just to mention where $containerConfigCache->write() may be found.
I think now it's correct, the part
which are atomic.
goes after brackets and refers to component or other methods provided by Symfony
javiereguiluz
added
DependencyInjection
Status: Reviewed
and removed
Status: Needs Review
labels
carsonbot
changed the title
|
Merged! Thanks Andrii. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mention where to find ConfigCache class. To be used in $containerCache->write()