[AssetMapper] Clarify dynamic import behavior#22013
Open
lacatoire wants to merge 2 commits intosymfony:7.4from
Open
[AssetMapper] Clarify dynamic import behavior#22013lacatoire wants to merge 2 commits intosymfony:7.4from
lacatoire wants to merge 2 commits intosymfony:7.4from
Conversation
The previous wording implied that AssetMapper doesn't work with dynamic imports, which is misleading. AssetMapper does rewrite dynamic imports when the path is a string literal. The actual limitation is that the es-module-shims polyfill only shims import map support, not the import() syntax itself — which is a native JS feature unsupported in very old browsers (mainly IE 11). Also add a note about transpilation order: transpilers must run before AssetMapper compilation to avoid breaking versioned URLs.
Collaborator
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
carsonbot
changed the title
Contributor
|
Please change target branch to 7.4, if a feature (like this one) was introduced in 7.3. We don't maintain the code, nor the docs of 7.3 anymore. That said, the version added should always be the correct one, like 7.3 here. Thank you |
OskarStark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clarifies the note about dynamic imports in the AssetMapper documentation.
Fixes #22012