-
Notifications
You must be signed in to change notification settings - Fork 2
(+semver: patch) Add documentation #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
annymsMthd
wants to merge
1
commit into
master
Choose a base branch
from
feature/add-documentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,54 @@ | ||
| # proto-schema-registry | ||
| # proto-schema-registry | ||
|
|
||
| [](https://github.com/syncromatics/proto-schema-registry/workflows/build/badge.svg) | ||
| [](https://goreportcard.com/report/github.com/syncromatics/proto-schema-registry) | ||
|
|
||
| Proto Schema Registry provides a service to store proto schemas in kafka. It also supports breaking change detection and versioning. | ||
| Protobuf generated code is both backwards and forward compatible but this service provides a means for other services that don't have | ||
| the generated protobuf objects the ability to decode and display messages. | ||
|
|
||
| ## Getting Started | ||
|
|
||
| ### Installing | ||
|
|
||
| #### Docker | ||
| ```docker run -e KAFKA_BROKER=broker:9092 -e PORT=443 syncromatics/proto-schema-registry:v0.7.1``` | ||
|
|
||
| | Environment Variable | Description | | ||
| |---------------------------|------------------------------------------------------------------------------------------------| | ||
| | KAFKA_BROKER | A seed kafka broker used to discover the cluster that schema will be stored in. (required) | | ||
| | PORT | The port the grpc service will be hosted at. (required) | | ||
| | REPLICATION_FACTOR | The replication factor of the schema topic. (defaults to 3) | | ||
| | SECONDS_TO_WAIT_FOR_KAFKA | The seconds to wait for kakfa to be available before the service panics (defaults to 30). | | ||
|
|
||
| ### Usage | ||
|
|
||
| Check out the [Protobuf Definition](docs/protos/proto/schema/registry/v1/registry_api.proto). | ||
|
|
||
| Once the service is up and running use the `RegisterSchema` grpc method to register a schema. The schema must be gzipped in the message. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be better as a list than a paragraph, can you list all three services along with use case? |
||
| You can retrieve schemas by id using the `GetSchema` grpc method. Before the schema is sent it should be extracted from the proto message | ||
| by using the [ExtractSchema](pkg/protobuf/extractor.go) function available in `pkg`. This will flatten out the object definition and | ||
| generate one file. | ||
|
|
||
| ## Development | ||
|
|
||
| ### Requirements | ||
|
|
||
| This project requires at least [Go](https://golang.org/dl/) 1.13.1. | ||
|
|
||
| ### Building | ||
|
|
||
| To build and test the project simply run ```make test```. | ||
|
|
||
| ## Built With | ||
|
|
||
| * [proto](https://github.com/emicklei/proto) - Decoder for protobuf files. | ||
|
|
||
| ## License | ||
|
|
||
| This project is licensed under the MIT License - see the [LICENSE.md](LICENSE.md) file for details | ||
|
|
||
| ## Acknowledgments | ||
|
|
||
| * [proto](https://github.com/emicklei/proto) for decoding proto files without the need for protoc | ||
| * [Visual Studio Code](https://code.visualstudio.com/) for just being an all around great editor | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compile-time vs. run-time is implied here, but newcomers to the project might understand the README more quickly if you called it out explicitly