Skip to content

Conversation

tomasz1986
Copy link
Member

fix(syncthing): add note about --no-console requiring Command Prompt

Clarify that the --no-console option only works when the Command
Prompt is set to be the default Windows shell. On the other hand, the
option does nothing when the default shell is set to Windows Terminal.

Signed-off-by: Tomasz Wilczyński [email protected]

Clarify that the `--no-console` option only works when the Command
Prompt is set to be the default Windows shell. On the other hand, the
option does nothing when the default shell is set to Windows Terminal.

Signed-off-by: Tomasz Wilczyński <[email protected]>
@tomasz1986
Copy link
Member Author

@calmh Please don't mind a quick question, but I'm just really unsure. Should this be prefixed with "fix(syncthing)" (as is right now) or rather "fix(users/syncthing)" or maybe just "fix(users)"?

@calmh
Copy link
Member

calmh commented Aug 31, 2025

Unsure, unclear if the scope adds much value anyway. We might just skip them entirely for the docs repo?

@tomasz1986
Copy link
Member Author

Unsure, unclear if the scope adds much value anyway. We might just skip them entirely for the docs repo?

Do you mean like in the old days, just without capitalisation? 😀

users/syncthing: add note about --no-console requiring Command Prompt

@acolomb
Copy link
Member

acolomb commented Sep 1, 2025

He was not saying to leave out the type (fix), but the scope (where it applies).

@tomasz1986 tomasz1986 changed the title fix(syncthing): add note about --no-console requiring Command Prompt fix(users/syncthing): add note about --no-console requiring Command Prompt Sep 1, 2025
@tomasz1986
Copy link
Member Author

tomasz1986 commented Sep 1, 2025

Ah, I see. I'm not really sure about that then, as most of the commits do seem to have their scope clearly stated. I personally find it useful when skimming through the commit list.

In this particular case, I think it is mostly the name of the file (syncthing) that doesn't add much value. This is different with others like autostart, ignoring, etc.

@tomasz1986 tomasz1986 changed the title fix(users/syncthing): add note about --no-console requiring Command Prompt fix(syncthing): add note about --no-console requiring Command Prompt Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants