You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I work at Badger DAO and we are using this library in our Github action's workflow, we occasionally encounter inconsistent behavior. While it often executes as expected, there are instances where we face the following error:
[switchToMetamaskNotification] Max amount of retries to switch to metamask notification window has been reached. It was never found.
Does it fix any issue?
Increase retries helped us to make Github action's workflow always works for us
We have set RETRIES_SWITCH_TO_METAMASK_NOTIFICATION=100 in our .env file, but we're still using the default setting for RETRIES_WAIT_TO_BE_HIDDEN. I've added instructions for others who might want to change this default value.
Sorry for the long response time. I'm down to merge the change to RETRIES_SWITCH_TO_METAMASK_NOTIFICATION. Adding RETRIES_WAIT_TO_BE_HIDDEN makes no sense at all so it should be removed. What's the motivation behind CONFIRM_TRANSACTION_RETRIES_LIMIT? 120s is already high enough imo but I might be missing some important context here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
I work at Badger DAO and we are using this library in our Github action's workflow, we occasionally encounter inconsistent behavior. While it often executes as expected, there are instances where we face the following error:
Does it fix any issue?
Increase retries helped us to make Github action's workflow always works for us
Quality checklist