Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes TypeScript type support for readonly arrays by updating the type definition to handle ReadonlyArray<any> instead of just Array<any> and improves array element type access.
- Updated the
Matchestype definition to support readonly arrays - Changed array element access from
Check[keyof Check]toCheck[number]for better type inference - Added comprehensive test coverage for both mutable and readonly array scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/index.js | Updated TypeScript type definition to support readonly arrays and improved array element access |
| index.test-d.ts | Added test cases to verify type behavior with both mutable and readonly arrays |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JounQin
commented
Oct 20, 2025
remcohaszing
approved these changes
Oct 20, 2025
|
@remcohaszing et al – any blockers to getting this merged? |
wooorm
approved these changes
Dec 15, 2025
This comment has been minimized.
This comment has been minimized.
|
Thanks for the merge @wooorm — can we also get a release? 🙏 |
Member
|
right, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
close #39