Skip to content

remove mgmt_group_ids field from onboarding module #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-shah wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove mgmt_group_ids field from onboarding module #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/examples/modular_organization/onboarding_with_posture.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ module "onboarding" {
subscription_id = "test-subscription"
tenant_id = "test-tenant"
is_organizational = true
management_group_ids = ["mgmt-group-id1", "mgmt-group-id2"] // if not provided, takes root management group by default

Copy link
Contributor

@ravinadhruve10 ravinadhruve10 Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we take care of it in config-posture module in L49 too?

Copy link
Contributor

@ravinadhruve10 ravinadhruve10 Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, one suggestion is to instead comment it out in every module under test example, similar to how we did it for other cloud provider TF repos.

# Optional: pre-existing SP pointing to Sysdig Onboarding App ID
onboarding_service_principal = "onboarding-service-principal-id"
Expand Down