Merged
Conversation
Apply PHP 8.4 language features using Rector and update tooling configs: - Add typed constants (AddTypeToConstRector) across ~40 files - Convert eligible classes to readonly (ReadOnlyClassRector) in ~20 files - Use constructor promotion in 6 Entity classes - Apply new-without-parentheses syntax in 3 files - Convert closures to arrow functions in 4 files - Apply various minor Rector rules (ReadOnlyPropertyRector, etc.) - Remove dead ErrorController and orphaned Exception template - Update rector.php (php84: true), psalm.xml (phpVersion 8.4), .php-cs-fixer.dist.php (new_expression_parentheses) All tests pass: 607 PHPUnit tests, 174 Behat scenarios. Co-Authored-By: OpenCode <noreply@opencode.ai>
0x46616c6b
force-pushed
the
php84-modernization
branch
from
d1a71f6 to
edf4665
Compare
Test sending welcome emails including locale forwarding to builder and behavior when no default domain is configured. Co-Authored-By: OpenCode <noreply@opencode.ai>
0x46616c6b
force-pushed
the
php84-modernization
branch
from
78012a8 to
830220a
Compare
|
0x46616c6b
requested review from
doobry-systemli,
t2d and
y3n4
as code owners
y3n4
pushed a commit
that referenced
this pull request
Feb 10, 2026
* ♻️ Modernize codebase for PHP 8.4 Apply PHP 8.4 language features using Rector and update tooling configs: - Add typed constants (AddTypeToConstRector) across ~40 files - Convert eligible classes to readonly (ReadOnlyClassRector) in ~20 files - Use constructor promotion in 6 Entity classes - Apply new-without-parentheses syntax in 3 files - Convert closures to arrow functions in 4 files - Apply various minor Rector rules (ReadOnlyPropertyRector, etc.) - Remove dead ErrorController and orphaned Exception template - Update rector.php (php84: true), psalm.xml (phpVersion 8.4), .php-cs-fixer.dist.php (new_expression_parentheses) All tests pass: 607 PHPUnit tests, 174 Behat scenarios. Co-Authored-By: OpenCode <noreply@opencode.ai> * ✅ Add tests for WelcomeMessageSender Test sending welcome emails including locale forwarding to builder and behavior when no default domain is configured. Co-Authored-By: OpenCode <noreply@opencode.ai> --------- Co-authored-by: OpenCode <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
php84: trueErrorControllerand orphanedException/show.html.twigtemplateChanges
PHP 8.4 Language Features (via Rector)
AddTypeToConstRector): ~40 files —public const NAME =→public const string NAME =ReadOnlyClassRector): ~20 files —final class→final readonly classwhere all properties are already readonlyClassPropertyAssignToConstructorPromotionRector): 6 Entity files (Setting, Voucher, ApiToken, WebhookDelivery, WebhookEndpoint, UserNotification)NewMethodCallWithoutParenthesesRector): 3 files —(new Foo())->bar()→new Foo()->bar()ClosureToArrowFunctionRector): 4 filesReadOnlyPropertyRector,PrivatizeFinalClassPropertyRector,NullToStrictStringFuncCallArgRector,ClassConstantToSelfClassRector, etc.Dead Code Removal
src/Controller/ErrorController.php(dead since Symfony 6 upgrade — no longer registered in framework config)templates/Exception/show.html.twig(orphaned template)Tooling Config Updates
rector.php: Added->withPhpSets(php84: true)+ skip rules for SonataAdmin controllerspsalm.xml:phpVersion="8.2"→phpVersion="8.4".php-cs-fixer.dist.php: Added'new_expression_parentheses' => trueVerification
All tools pass cleanly:
This PR was generated by OpenCode.