-
Notifications
You must be signed in to change notification settings - Fork 0
MOB-5193 HP4U Data API #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sanjacurcic-taboola
wants to merge
5
commits into
main
Choose a base branch
from
MOB-5193-hp4u-data-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3d01a76
MOB-5193 HP4U Data API
sanjacurcic-taboola 2e01bc4
MOB-5193 Updated compileSdk and targetSdk versions
sanjacurcic-taboola 1aa4bad
Added when statement instad of if and added code comments
sanjacurcic-taboola b3baeb6
PR fixes
sanjacurcic-taboola 86acf20
Fixed code formatting
sanjacurcic-taboola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
...n/java/com/taboola/hp4udemoapplication/adapters/articles/HomePageDataApiItemViewHolder.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.taboola.hp4udemoapplication.adapters.articles | ||
|
|
||
| import android.view.View | ||
| import android.widget.ImageView | ||
| import android.widget.TextView | ||
| import androidx.core.view.isVisible | ||
| import androidx.recyclerview.widget.RecyclerView | ||
| import com.squareup.picasso.Picasso | ||
| import com.taboola.hp4udemoapplication.R | ||
| import com.taboola.hp4udemoapplication.model.Article | ||
| import com.taboola.hp4udemoapplication.view.AnimatedBackgroundTextView | ||
|
|
||
| class HomePageDataApiItemViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) { | ||
|
|
||
| private val title: TextView? | ||
| get() = itemView.findViewById(R.id.title) | ||
|
|
||
| private val content: TextView? | ||
| get() = itemView.findViewById(R.id.content) | ||
|
|
||
| private val image: ImageView? | ||
| get() = itemView.findViewById(R.id.image) | ||
|
|
||
| private val animatedBackgroundTextView: AnimatedBackgroundTextView? | ||
| get() = itemView.findViewById(R.id.swapped_indication) | ||
|
|
||
| fun onBind(article: Article) { | ||
| animatedBackgroundTextView?.isVisible = article.isSwapped | ||
| title?.text = article.title | ||
| content?.text = article.content | ||
| if (article.isSwapped) { | ||
| Picasso.get().load(article.url).into(image) | ||
| } else { | ||
| Picasso.get().load(article.imageResourceId).into(image) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjacurcic-taboola - Notice that you changed the major version (from three to four). I would make sure nothing was impacted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already checked the entire app, everything seems fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjacurcic-taboola - Remember you can only merge this once 4.0.17 has been released officially.