-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[amdgpu] LLVM 20 updates for AMD MI3xx GPUs #8793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmm77
wants to merge
52
commits into
taichi-dev:master
Choose a base branch
from
ROCm:amd-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
e4a5be3
modifications to microbenchmark suite to run on AMD GPUs
tmm77 e932646
adding arguments for selecting a list of architectures and benchmark …
tmm77 8a9ca3b
additional modifications for single arch and benchmark plan runs
tmm77 6e4fb08
temporarily setting atomic ops repeat to 1
tmm77 efe237e
updating vulkan sdk downlaod url
tmm77 c3d7b84
removing comments for saving json files
tmm77 eeb3354
Merge pull request #1 from AMD-AI/mintz/parameterize_microbenchmark
tmm77 bb8a9b3
Patch to avoid the need to fetch to build Taichi wheel
c137b06
fix: Patch to avoid the need to fetch source to build Taichi wheel
bhaveshlad27 b74c00c
Taicho Multistage Dockerfile
6b0f58b
Taichi Multistage Dockerfile
bhaveshlad27 f791165
setting architecture to gpu
tmm77 1a6520a
ROCm port of taichi
bhatturu 86b6184
Merge pull request #3 from taichi-dev/master
tmm77 9260d4e
Merge branch 'amd-develop' into master
tmm77 712d405
Merge pull request #4 from ROCm/master
tmm77 46444ee
Merge branch 'amd-integration' into amd-develop
tmm77 5eed1b4
Merge pull request #5 from ROCm/amd-develop
tmm77 0f2615c
LLVM-20
johnnynunez c189397
Update LLVM API calls in codegen_cuda.cpp for compatibility with rece…
johnnynunez 23478fd
Add CHANGELOG.md to document recent updates and improvements
johnnynunez c5edfdb
Fix include directive for IR analysis header in codegen_cuda.cpp
johnnynunez 2d4703f
Refactor JIT compilation in CUDA: update function pointers, enhance P…
johnnynunez d2c87f6
Update header includes and fix LLVM API calls in CPU code generation
johnnynunez ad65ec9
Fix header include for program in codegen_cpu.cpp
johnnynunez 1be07f3
cmake build updates, header fixes; Merging from commits ebdc72be75443…
tmm77 de14f98
implementing error function and cuda updates; merging 5449f722e796fac…
tmm77 c984b3c
removing updates for blackwell
tmm77 f5118a7
removing blackwell updates; restoring window_base.cpp include
tmm77 78d9213
additional cuda updates for llvm20; merging from 8ca16de9a24e82baaed1…
tmm77 d20c823
additional updates for llvm 20
tmm77 f0ca790
fix build issues with llvm 20 update
tmm77 26ae12c
updated AMD Instinct GPU jit implementation to llvm 20
tmm77 514446e
updating amd gpu kernel code generation to llvm 20
tmm77 2a6adb0
fix object file type; setting llvm dir based on environment var
tmm77 5516360
adding bitcode for gfx940,gfx941,gfx942,gfx950
tmm77 48cc4f7
adding patch for changes to external spdlog
tmm77 76c25df
Merge pull request #6 from ROCm/mintz/llvm20_update
tmm77 ed925e6
updating dockerfile for llvm 20
tmm77 a78aaca
Update Dockerfile to fix pipeline issues
deepsek 2549e39
dockerfile copy dir
deepsek 300196b
Dockerfile reformat
deepsek 8dab171
CI: Fix Dockerfile issues
deepsek ed1c61d
Fix Tester Issues
deepsek 29c4129
removing any existing build cache
tmm77 7b155bb
Fix Version Issues
deepsek 104dc18
Merge branch 'amd-integration' into release/1.8.0b2
deepsek 13a0550
Docs: Taichi component, configs and setup for 25.11 release (#2)
anisha-amd 39cc7fe
Merge pull request #8 from ROCm/release/1.8.0b2
tmm77 36c0aa5
removing rocm_setup_version
tmm77 7c446fb
Update taichi-install.rst
anisha-amd f47d1b8
removing pull_request.yml for security concerns
tmm77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LLVM_DIR hardcoded to Linux path for all platforms
Medium Severity
The final
LLVM_DIRassignment unconditionally sets it to/usr/lib/llvm-20/cmakefor all non-ARM-Linux, non-AMDGPU platforms, including macOS and Windows. The original code usedstr(out)which pointed to the platform-specific downloaded LLVM path. This overwrites the correctout-based paths for Darwin and Windows, breaking LLVM discovery on those platforms. Similarly,CUDA_HOMEandCPATHare set to Linux-specific paths.Reviewed by Cursor Bugbot for commit f47d1b8. Configure here.