river: Set queue names when inserting jobs via trigger#4431
Merged
mastercactapus merged 18 commits intomasterfrom Oct 24, 2025
Merged
river: Set queue names when inserting jobs via trigger#4431mastercactapus merged 18 commits intomasterfrom
mastercactapus merged 18 commits intomasterfrom
Conversation
…es for entity_updates
…n from database for testing
…e unnecessary row scanning
AlaricWhitney
approved these changes
Oct 24, 2025
cgray
approved these changes
Oct 24, 2025
ethan-haynes
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The recent changes for direct-to-queue jobs left out the
queue_namecolumn, resulting in all change-triggered jobs going into thedefaultqueue, rather than dedicated ones. Additionally, while things should still "work" it means the notifications don't actually get sent to the right place and so jobs are only picked up via the polling fallback mechanism.This PR corrects this by creating a util function for inserting jobs that handles setting the correct values.
Additional Context
This is a largely "it works or it doesn't work at all"-PR, there's good test coverage on the affected features/modules. It boils down to a single migration replacing various functions (down migration contains the original for comparison)