Added more json fields to AlertStatus webhook notification#4445
Open
MichaelUray wants to merge 9 commits intotarget:masterfrom
Open
Added more json fields to AlertStatus webhook notification#4445MichaelUray wants to merge 9 commits intotarget:masterfrom
MichaelUray wants to merge 9 commits intotarget:masterfrom
Conversation
for AlertStatus updates: Summary string Details string ServiceID string ServiceName string Meta map[string]string Before these fields were only available in Alert notifications and it was not possible to send them to the user with acknowledge or close events.
notification for Alart and AlartStatus Before was that field not available and it was not possible to send them to the user with messages.
mastercactapus
requested changes
Nov 28, 2025
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
AlertURL contains the full link to the alert page, or to the alarm list of the according service if it is an alert bundle.
mastercactapus
requested changes
Dec 11, 2025
Comment on lines
+133
to
+142
| @@ -127,13 +139,20 @@ func (s *Sender) SendMessage(ctx context.Context, msg notification.Message) (*no | |||
| ServiceID: m.ServiceID, | |||
| ServiceName: m.ServiceName, | |||
| Count: m.Count, | |||
| AlertURL: fmt.Sprintf("%s/services/%s/alerts", pubURL, m.ServiceID), | |||
Member
There was a problem hiding this comment.
These need to use cfg.CallbackURL which accounts for things like the short URL generation
for example cfg.CallbackURL(fmt.Sprintf("/services/%s/alerts", m.ServiceID))
fmt.Sprintf("%s/alerts/%d", pubURL, m.AlertID)
with
cfg.CallbackURL(fmt.Sprintf("/alerts/%d", m.AlertID))
- Rename AlertURL to GoAlertURL as suggested, since the URL points to GoAlert itself, not to anything notification-specific - Remove unused pubURL variable (cfg.CallbackURL is used instead) - Remove unused strings import
Author
|
@mastercactapus thanks for the review. All feedback is addressed in the latest commits:
The final layout:
Ready for another look when you have a minute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added more json fields to the AlertStatus webhook notification.
Added
make testin documentation "Contributing to GoAlert".