fix: use applicationName config in nav bar and login page#4482
Open
mattklaver-hs wants to merge 1 commit intotarget:masterfrom
Open
fix: use applicationName config in nav bar and login page#4482mattklaver-hs wants to merge 1 commit intotarget:masterfrom
mattklaver-hs wants to merge 1 commit intotarget:masterfrom
Conversation
The application name was hardcoded as "GoAlert" in NavBar.tsx and Login.tsx. These components now read from the applicationName value already exported by env.ts, which is populated from the server-side General.ApplicationName config. The browser tab title already used this value correctly; this makes the top-left display consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
The application name was hardcoded as "GoAlert" in NavBar.tsx and Login.tsx. These components now read from the applicationName value already exported by env.ts, which is populated from the server-side General.ApplicationName config. The browser tab title already used this value correctly; this makes the top-left display consistent.
Which issue(s) this PR fixes:
Fixes #4481
Describe any introduced user-facing changes:
Results in expected behavior when modifying the Application Name config value.