Skip to content

Php 8.x compliance #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meyerauslander wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Php 8.x compliance #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f1663f
Update class-wc-taxjar-integration.php for php 8.x
Mar 10, 2025
6db0611
Update class-wc-taxjar-tax-calculation.php for php 8.x
Mar 10, 2025
2f69770
Update class-wc-taxjar-download-orders.php for php 8.x
Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions includes/class-taxjar-tax-calculation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
*/
class TaxJar_Tax_Calculation {

/* Define props to avoid php 8.x dynamic prop deprecation warnings. */
public $cache_time;

public function __construct() {
// Cache rates for 1 hour.
$this->cache_time = HOUR_IN_SECONDS;
Expand Down
4 changes: 4 additions & 0 deletions includes/class-wc-taxjar-download-orders.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@

class WC_Taxjar_Download_Orders {

/* Define props to avoid php 8.x dynamic prop deprecation warnings. */
public $integration;
public $taxjar_download;

public function __construct( $integration ) {
$this->integration = $integration;
$this->taxjar_download = filter_var( $this->integration->get_option( 'taxjar_download' ), FILTER_VALIDATE_BOOLEAN );
Expand Down
10 changes: 10 additions & 0 deletions includes/class-wc-taxjar-integration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ class WC_Taxjar_Integration extends WC_Settings_API {

protected static $_instance = null;

/* Define props to avoid php 8.x dynamic prop deprecation warnings. */
public $tax_calculations;
public $method_title;
public $method_description;
public $integration_uri;
public $debug;
public $module_loader;
public $customer_sync;
public $transaction_sync;
public $download_orders;
public static $app_uri = 'https://app.taxjar.com/';

/**
Expand Down