Skip to content

fix: Apply end_context when end/exit is a sequence step #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lykinsbd merged 1 commit into from
Mar 2, 2026
Merged

fix: Apply end_context when end/exit is a sequence step #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions ssh_server/handlers/ciscohandlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,10 @@ func handleShellInput(t *term.Terminal, userInput string, fd *fakedevices.FakeDe
return true
}

// Apply context switch if the input matches a context_search key.
// Uses starts-with-N-words semantics so "interface Gi0/0/2" matches key "interface".
// In scenario mode (active sequence), context switches only fire when the sequence
// step was just handled — enforcing strict command ordering.
inScenario := seqIdx != nil && *seqIdx < len(sequence)

// Apply context switch if the input matches a context_search key.
// In scenario mode, only fires when the sequence step was just handled.
if !inScenario || sequenceHandled {
if matchedCtx, ok := matchContextKey(userInput, fd.ContextSearch); ok {
t.SetPrompt(devicePrompt(fd, fd.ContextSearch[matchedCtx]))
Expand All @@ -93,19 +92,23 @@ func handleShellInput(t *term.Terminal, userInput string, fd *fakedevices.FakeDe
}
}

if sequenceHandled {
return false
// exit/end: always apply when sequence step matched; in non-scenario mode always apply;
// in scenario mode "end" is blocked unless it was the current step.
if userInput == "exit" || userInput == "end" {
if sequenceHandled || !inScenario || userInput == "exit" {
return handleExitEnd(t, userInput, fd, contextState)
}
}

if userInput == "exit" {
return handleExitEnd(t, userInput, fd, contextState)
if sequenceHandled {
return false
}

// In scenario mode, "end" is blocked unless it was the current sequence step
if userInput == "end" && !inScenario {
return handleExitEnd(t, userInput, fd, contextState)
}
return handleStateCommands(t, userInput, fd, contextState)
}

// handleStateCommands handles reset state, hostname changes, and supported command dispatch.
func handleStateCommands(t *term.Terminal, userInput string, fd *fakedevices.FakeDevice, contextState *string) bool {
if userInput == "reset state" {
t.Write(append([]byte("Resetting State..."), '\n'))
*contextState = fd.ContextSearch["base"]
Expand Down
Loading