chore: Fix Go Report Card issues - #55
Merged
Merged
Conversation
- Apply gofmt formatting to ciscohandlers_test.go, sshlistners_test.go, and cmdmatch.go - Refactor GenericCiscoHandler: extract handleShellInput and dispatchCommand helpers, reducing cyclomatic complexity from 22 to <15 - Add golangci-lint to CI workflow with .golangci.yml config Closes #54
- gofmt: format dispatchCommand function - misspell: fix 'Listners' -> 'Listeners' in package comment - staticcheck SA9003: remove empty branch in test server goroutine
Contributor
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all findings from Go Report Card (#54).
Changes
ciscohandlers_test.go,sshlistners_test.go,cmdmatch.goGenericCiscoHandler— extracthandleShellInputanddispatchCommandhelpers, reducing complexity from 22 → 11/8 (both under threshold of 15)golangci-lint-actiontotest.ymlwith.golangci.ymlconfig (gofmt, govet, misspell, gocyclo, ineffassign, staticcheck)Coverage
93.6% (up from 93.0% — refactoring improved testability of dispatch logic)
Closes #54