Add WEB_FEATURES.yml #4599
Open
Add WEB_FEATURES.yml #4599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and cleans up Math files for `number`
Fixes error when linting the `json-modules` feature which points to test/language/import/import-attributes, containing .json fixture files. The linter's file_is_test() function was only filtering out FIXTURE.js files but not .json files, so it tried to read frontmatter from the JSON files and failed.
Tweak classifications
These were not included due to an oversight in the web-features project which has since been corrected: web-platform-dx/web-features#3434
|
I recognized a few opportunities for improvements to this changeset. Since no one has had an opportunity to review it, yet, I went ahead and made those improvements directly. |
|
We discussed this in the maintainers meeting. Makes sense for @jugglinmike to make changes to these files directly while the workflow is in development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in gh-4567 and designed in gh-4571.
This patch includes a rudimentary linting tool for local use. Would you folks support a follow-up patch to introduce a new GitHub Workflow which uses it to validate pull requests?