Updating catch to 2.13.10 #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimci86
approved these changes
Jan 22, 2023
Contributor
kimci86
left a comment
kimci86
left a comment
There was a problem hiding this comment.
I confirm compiling tests on Apple Silicon platform fails, this PR fixes it and it provides the latest Catch2 release from v2.x branch. This is good to merge!
Contributor
|
@tcbrindle Could you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch 2.9.2 is not compatible with Apple Silicon causing compilation errors on Mac. Updating catch to 2.13.10 solves compilation errors.
Trying to build 2.9.2 on apple silicon causes similar error to: CoatiSoftware/Sourcetrail#1185