tweak: Reduce non-required pub visibility.

[tcrypt25519]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/jet_ir/src/lib.rs	52% smaller
crates/jet_runtime/src/lib.rs	25% smaller

[gemini-code-assist]

Summary of Changes

Hello @tcrypt25519, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the jet_ir and jet_runtime crates by adjusting module visibility. The primary goal is to improve code encapsulation and reduce the exposed public API surface by making certain modules private where their contents are still publicly re-exported, leading to a cleaner and more maintainable internal structure.

Highlights

• Module Visibility Reduction: The constants and types modules within crates/jet_ir/src/lib.rs have been changed from public (pub mod) to private (mod). Similarly, the binding module in crates/jet_runtime/src/lib.rs has also had its visibility reduced. This refactoring improves encapsulation by making these modules internal while their necessary public items continue to be re-exported.

Changelog

• crates/jet_ir/src/lib.rs
  • Changed constants module from public to private.
  • Changed types module from public to private.
• crates/jet_runtime/src/lib.rs
  • Changed binding module from public to private.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reduces the visibility of several modules to limit the public API surface, which is a good practice. My review includes a suggestion to restore the crate-level documentation in jet_ir that was removed, as it provides important context for the crate.

[gemini-code-assist]

The crate-level documentation was removed. It's good practice to keep it to explain the purpose of the crate. Please restore it as inner documentation comments (//!) at the top of the file.

Suggested change

	mod constants;
	mod types;
	//! Shared LLVM IR types and constants.
	//! This crate contains the unified type system used by both the runtime builder
	//! and contract builder to ensure consistent memory layouts.
	mod constants;
	mod types;

[Copilot]

Pull request overview

This pull request improves API encapsulation by reducing unnecessary pub visibility on internal modules. The changes make three modules private while maintaining their public APIs through re-exports, following Rust best practices for clean API design.

Changes:

• Made jet_runtime::binding module private (contains only Display trait implementations)
• Made jet_ir::constants and jet_ir::types modules private while maintaining their public items via re-exports

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/jet_runtime/src/lib.rs	Changed binding module from pub mod to mod - contains only trait implementations, not part of public API
crates/jet_ir/src/lib.rs	Changed constants and types modules from pub mod to mod, removed redundant documentation comments - all items remain accessible via pub use re-exports