Type checking error when using include_dir on windows #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When records inherit from multiple interfaces that share a common parent
interface (diamond inheritance), the interface_list was incorrectly
containing duplicate entries. For example:
local interface A end
local interface B is A end
local interface C is A end
local record D is B, C end -- interface_list was {B, A, C, A}
This was caused by the collect_interfaces function adding interfaces to
the list before checking if they had already been seen. The fix ensures
that interfaces are only added to the list if they haven't been
processed before, maintaining the correct order while eliminating
duplicates.
The interface_list for the example above now correctly contains {B, A, C}.
Changes:
- Fixed collect_interfaces() in context.lua and tl.lua to check seen[] before insert
- Added comprehensive test case for diamond inheritance scenarios
- Preserves interface order for proper conflict resolution
Fixes the issue where duplicate entries appeared in complex interface
hierarchies while maintaining deterministic behavior for type checking.
|
Teal Playground URL: https://1077--teal-playground-preview.netlify.app |
Collaborator
|
Did you mean to open this PR with this title+description? the changes are unrelated |
Collaborator
|
seems like you accidentally did a PR for #1076 twice 😆 |
Contributor
Author
|
oops! sorry |
Contributor
Author
|
I made a mistake. |
Member
|
Closing this one since it's the wrong commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix path normalization issue causing type mismatches on Windows
The same type was being seen as mismatching because of different path
representations, even though the paths referred to the same file.
For example, "src\cc.d.tl:6" vs ".\src/cc.d.tl:6" would be treated
as different files, causing type comparison failures.
Changes:
it available to the core type checking system
This ensures all file paths are converted to a canonical form before
being used for type checking, file loading, and module resolution,
preventing the same file from being treated as different files when
referenced with different path representations.
Fixes the issue where global_env_def modules would cause type errors
on Windows due to inconsistent path normalization between backslashes
and forward slashes, relative and absolute paths.