add transit by foot#547
Open
simupoppo wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
徒歩連絡の距離計算は |
teamhimeh
reviewed
May 31, 2026
| // Only for the pax category, never for mail or goods. | ||
| if( welt->get_settings().is_transit_by_foot() && is_enabled(goods_manager_t::INDEX_PAS) ) { | ||
| const uint16 cov = welt->get_settings().get_station_coverage(); | ||
| for( auto &other_halt : alle_haltestellen ) { |
Owner
There was a problem hiding this comment.
他の駅を全走査すると駅の数が増えた時が辛いので、対象駅の集客範囲内のタイルをチェックする方が大規模マップで計算量が増えにくいです。
Owner
|
コードの変更内容を分析し、変更を網羅するための手動テストケースを作成しました。 提案する手動テストケース
(Automated PR test case generation by AI agent) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
徒歩連絡機能を実装しました。
station_coverageの範囲にある駅に有効です