Fix crash when displaying vehicle overlay during route calculation#579
Merged
Conversation
simupoppo
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
経路計算中の画面更新で、空になっている経路の末尾を参照してクラッシュする問題を修正します。
原因
route_t::calc_route()は経路探索開始時に既存の経路をクリアします。探索中のINT_CHECK()から画面更新が実行されると、vehicle_t::display_overlay()が空の経路に対してback()を呼び、範囲外アクセスが発生していました。修正内容
back()とwelt->lookup()を呼ぶように変更NULLとして既存の表示処理を継続確認
make -j8成功git diff --check成功