Skip to content

BUG FIX: fix two GUI bugs in convoy detail window #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanyao1230 wants to merge 2 commits into
base: OTRP-KUTAv6
Choose a base branch
from
+5 −2
Open

BUG FIX: fix two GUI bugs in convoy detail window #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
965b4cf
BUG FIX: prevent combobox droplist scroll reset on every frame
kanyao1230 Jun 10, 2026
119ebaa
BUG FIX: fix upper section width flickering during convoy window resize
kanyao1230 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gui/components/gui_combobox.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,9 @@ void gui_combobox_t::set_size(scr_size size)
closed_size = size;
gui_component_t::set_size( size );

droplist.request_size(scr_size(this->size.w, droplist.get_size().h));
if( droplist.get_size().w != this->size.w ) {
droplist.request_size(scr_size(this->size.w, droplist.get_size().h));

@simupoppo simupoppo Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほかのcomboboxでも問題なく動作することを一応確認・コメントしてください

}

textinp.set_size( scr_size( size.w - bt_prev.get_size().w - bt_next.get_size().w - D_H_SPACE, closed_size.h ) );
set_pos(get_pos());
Expand Down
3 changes: 2 additions & 1 deletion gui/convoi_info_t.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,9 +495,10 @@ void convoi_info_t::draw(scr_coord pos, scr_size size)
route_show_button.pressed = is_route_show;
route_show_button.enable();

// update layout before rendering so upper section width matches current window size
set_windowsize(size);
// all gui stuff set => display it
gui_frame_t::draw(pos, size);
set_windowsize(size);
}


Expand Down
Loading