[FEAT/#304] 온보딩 뷰 / 필터링 건너뛰기 추가 #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledeggg
approved these changes
Dec 12, 2024
Member
boiledeggg
left a comment
boiledeggg
left a comment
There was a problem hiding this comment.
수고하셨습니닷~~ 빨리 머지해서 immutable 같이 씁시다!
| MainBottomBar( | ||
| isVisible = navigator.showBottomBar(), | ||
| tabs = MainTab.entries.toList(), | ||
| tabs = MainTab.entries.toImmutableList(), |
| coroutines-test = { group = "org.jetbrains.kotlinx", name = "kotlinx-coroutines-test", version.ref = "coroutine" } | ||
| kotlin = { group = "org.jetbrains.kotlin", name = "kotlin-stdlib", version.ref = "kotlin" } | ||
| kotlin-gradlePlugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" } | ||
| kotlin-collections-immutable = { group = "org.jetbrains.kotlinx", name = "kotlinx-collections-immutable", version.ref = "kotlinx-collections-immutable" } |
Comment on lines
76
to
77
| onButtonClick: () -> Unit, | ||
| onTextClick: () -> Unit, |
Member
There was a problem hiding this comment.
StartFilteringScreen 컴포저블은 이 파일에서만 쓰이는거 같은데 이벤트 이름들을 조금 더 직관적으로 가져가면 어떨까 싶네요!
코드 읽기가 더 수월해질 것 같아요~!
Hyobeen-Park
approved these changes
Dec 17, 2024
Member
Hyobeen-Park
left a comment
Hyobeen-Park
left a comment
There was a problem hiding this comment.
수고하셨습니다!!!! 얼른 저도 immutableList 적용할게요~~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
Screen_Recording_20241210_034553_terning.mp4
Screen_Recording_20241210_035400_One.UI.Home.mp4
📢 To Reviewers