Skip to content

Nominate khrm and aThorp96 as pipeline approvers#9519

Open
vdemeester wants to merge 1 commit intomainfrom
promote-khrm-athorp96-to-approver
Open

Nominate khrm and aThorp96 as pipeline approvers#9519
vdemeester wants to merge 1 commit intomainfrom
promote-khrm-athorp96-to-approver

Conversation

@vdemeester
Copy link
Member

Changes

Nominate khrm and aThorp96 for promotion to pipeline approvers. Also adds aThorp96 to pipeline-reviewers.

Per the contributor ladder, nominees must agree to all requirements by commenting on this PR.

khrm — Activity (last 12 months)

Metric Pipeline Org-wide
DevStats contributions 112 1,013
PRs authored 11 (9 merged) 75
PR reviews 27 410
Comments 130 667
Issues 6 22

Already a pipeline reviewer. Lead maintainer of triggers (260 contributions) and results (534 contributions). Demonstrates broad cross-project knowledge and consistent high-quality reviews.

aThorp96 — Activity (last 12 months)

Metric Pipeline Org-wide
DevStats contributions 161 310
PRs authored 7 (all merged) 22
PR reviews 13 230
Comments 83 174
Issues 11 12

Active across multiple repos: operator (42 devstats), results (57), chains (27). Strong reviewer presence and growing contributor.

Maintainer Requirements Checklist

Both candidates meet the maintainer requirements:

  • Active reviewing for 3+ months
  • 30+ PRs authored/reviewed
  • Primary reviewer for 10+ substantial PRs
  • Broad knowledge of the project across multiple areas
  • Nominees: please comment confirming you agree to all maintainer responsibilities

Full triage report: https://gist.github.com/vdemeester/c7ce8d4fea6f7a2f9b3f685558ce8ded

Submitter Checklist

Release Notes

NONE

Nominate khrm and aThorp96 for promotion to pipeline approvers.
Also add aThorp96 to pipeline-reviewers.

khrm (last 12 months on pipeline):
- 112 devstats contributions
- 11 PRs authored (9 merged), 27 PR reviews, 130 comments
- Already a pipeline reviewer; also lead maintainer of triggers
  (260 contributions) and results (534 contributions)
- 1,013 total org-wide contributions, 410 reviews

aThorp96 (last 12 months on pipeline):
- 161 devstats contributions
- 7 PRs authored (all merged), 13 PR reviews, 83 comments, 11 issues
- Also active on operator (42), results (57), chains (27)
- 310 total org-wide contributions, 230 reviews

Both meet the maintainer requirements per the contributor ladder:
- 3+ months active reviewing
- 30+ PRs authored/reviewed
- Broad knowledge of the project
- Primary reviewer for substantial PRs

See the full triage report:
https://gist.github.com/vdemeester/c7ce8d4fea6f7a2f9b3f685558ce8ded

/kind misc
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2026
@tekton-robot tekton-robot requested review from afrittoli and dibyom March 6, 2026 10:22
@vdemeester
Copy link
Member Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Mar 6, 2026
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026
@afrittoli
Copy link
Member

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,waveywaves]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@waveywaves
Copy link
Member

/retest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2026
@tekton-robot
Copy link
Collaborator

@vdemeester: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants