fix(approval): preserve state and decisions when updating ApprovalRequest spec fields#317
Open
fix(approval): preserve state and decisions when updating ApprovalRequest spec fields#317
Conversation
…uest spec fields Refactor mutate to capture server-side state/decisions before applying spec updates, preventing already-decided ApprovalRequests from losing their granted state or recorded decisions on re-reconciliation. Add test for spec field updates preserving granted state and decisions.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ApprovalRequest builder reconciliation logic to allow spec updates on already-decided ApprovalRequests without clobbering decider-managed fields (state/decisions), addressing re-reconciliation scenarios where inputs change after a request was granted.
Changes:
- Preserve existing
spec.stateandspec.decisionswhenCreateOrUpdatemutates an already-decided ApprovalRequest, while still applying desired spec updates (target/requester/decider/action/strategy). - Ensure non-auto strategies explicitly keep
spec.stateasPendingonly for new/pending requests. - Add a test covering “spec field update on granted ApprovalRequest” to verify state/decisions are preserved.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| approval/api/v1/builder/builder.go | Refactors mutate logic to apply spec updates while preserving decider-managed state/decisions for already-decided ApprovalRequests. |
| approval/api/v1/builder/builder_test.go | Adds regression test ensuring spec updates don’t reset granted state or erase recorded decisions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor mutate to capture server-side state/decisions before applying spec updates, preventing already-decided ApprovalRequests from losing their granted state or recorded decisions on re-reconciliation.
Add test for spec field updates preserving granted state and decisions.
Problem: Already stale but granted AR cannot be updated due to webhook-freeze. Fix this by checking if update in webhook changes any relevant fields instead of global