Extract MergeStats and DedupPollers to common/taskqueue for reuse#9401
Open
rkannan82 wants to merge 4 commits intokannan/mcn_matching/business-id-patternsfrom
Open
Extract MergeStats and DedupPollers to common/taskqueue for reuse#9401rkannan82 wants to merge 4 commits intokannan/mcn_matching/business-id-patternsfrom
rkannan82 wants to merge 4 commits intokannan/mcn_matching/business-id-patternsfrom
Conversation
Add business ID extraction patterns for additional WorkflowService APIs to enable MCN single-cell routing based on various business identifiers. Co-authored-by: Cursor <cursoragent@cursor.com>
- Add common/taskqueue/stats.go with MergeStats, DedupPollers, AggregateStats - Update matching service to use shared helpers - Remove duplicate implementations from physical_task_queue_manager, matching_engine, and task_queue_partition_manager Made-with: Cursor
rkannan82
changed the base branch from
main
to
kannan/mcn_matching/business-id-patterns
Clone totalStats and merge partitionStats into it instead of merging both into an empty struct. Same result, clearer intent. Made-with: Cursor
Use require.InDelta for float comparisons per testifylint. Also fix import order per gci. Made-with: Cursor
rkannan82
force-pushed
the
kannan/mcn_matching/refactor-shared-stats
branch
from
81a575b to
09e9ef5
Compare
rkannan82
force-pushed
the
kannan/mcn_matching/business-id-patterns
branch
2 times, most recently
from
10aef0d to
96a62a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Extract shared task queue stats aggregation helpers (
MergeStats,DedupPollers,AggregateStats) intocommon/taskqueuepackage and update the matching service to use them.Why?
To repurpose these libraries when aggregating responses across cells.
How did you test it?
common/taskqueue/stats_test.go-TestMergeStats,TestDedupPollers)TestOldestBacklogAgefrom matching_engine_test (covered by taskqueue tests)Potential risks
Low. Pure refactor with no behavior change. The new package is used only by matching service code paths that previously had inline implementations.