fix: resolve git ref/SHA from checkout instead of GITHUB_REF#9411
Draft
chaptersix wants to merge 2 commits intotemporalio:mainfrom
Draft
fix: resolve git ref/SHA from checkout instead of GITHUB_REF#9411chaptersix wants to merge 2 commits intotemporalio:mainfrom
chaptersix wants to merge 2 commits intotemporalio:mainfrom
Conversation
For workflow_dispatch events, GITHUB_REF and GITHUB_SHA point to the branch the workflow was dispatched from, not the ref specified in inputs.ref. This caused Docker images to be tagged with the wrong branch name and SHA. The build-docker-images composite action now resolves the ref and SHA directly from the checked-out git tree, which is correct regardless of trigger type.
chaptersix
force-pushed
the
fix/docker-build-manual-ref-mismatch
branch
from
4c3ec5c to
3572f22
Compare
chaptersix
commented
Feb 26, 2026
Comment on lines
+66
to
+67
| REF=$(git symbolic-ref HEAD 2>/dev/null || git describe --tags --exact-match HEAD 2>/dev/null || git rev-parse HEAD) | ||
| echo "ref=${REF}" >> "$GITHUB_OUTPUT" |
Contributor
Author
There was a problem hiding this comment.
need to double check this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatch) tagging images with thewrong branch name and SHA.
GITHUB_REF/GITHUB_SHApoint to the branch theworkflow was dispatched from, not the
inputs.refthat was actually checked out.build-docker-imagescomposite action now resolves ref and SHA directly fromthe checked-out git tree via
git rev-parse HEAD/git symbolic-ref HEAD,which is correct regardless of trigger type.
GITHUB_SHA.