fix(explorer): tolerate per-token metadata failures on block page#1105
Open
web3jacker wants to merge 1 commit into
Open
fix(explorer): tolerate per-token metadata failures on block page#1105web3jacker wants to merge 1 commit into
web3jacker wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🩹 One bad token shouldn't blank out a whole block's events
Hey! Small but annoying one here.
On the block page we collect every TIP-20 address that shows up in the
receipts, then fetch metadata for all of them at once:
Problem:
Promise.allis all-or-nothing. If one token doesn't conform to theTIP-20 metadata interface, or the RPC just hiccups on a single call, the whole
thing rejects — and
blockKnownEventsQueryOptionsfails with it. So a singleweird token means none of the transactions on that block get their
known-events rendered. 😬
The funny thing is the receipts fetch right above it already does the right
thing with
.catch(() => null), and the loop that consumes the metadataalready null-checks each entry. So this was just an inconsistency.
The fix is to make the metadata fetch match:
Now a flaky/non-conforming token just doesn't get decorated metadata, and
everything else on the block renders fine. 👍