Fix sample(do=...) to follow the model dtype#27
Merged
Conversation
torch.full defaulted to float32, crashing sampling under do on a float64 model (flow.double(), e.g. for tight cross-implementation parity checks). Follow self._dtype like every other value tensor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H1WDjRpYVvCvFG99Lirnsi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.fulldefaulted to float32, crashingsample(do=...)on a float64 model (flow.double(), e.g. for tight cross-implementation parity checks). Followself._dtypelike every other value tensor.Found by the float64 parity tests of the JAX Bayesian twin in tramdag-simu (
tensorchiefs/tramdag-simubranchfeat/bayes-jax, PR to follow) — that work depends on this fix, so please merge this first; the sibling checkout there is pinned to this branch until then.🤖 Generated with Claude Code
https://claude.ai/code/session_01H1WDjRpYVvCvFG99Lirnsi