Conversation
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for multivec maxsim, introducing new methods to create and query multivec indexes alongside related registry and test updates. Key changes include:
- New methods in the client for creating multivec indexes and querying multivec search.
- Updates to the registry to register multivec columns and search them.
- Additional tests and documentation updates to cover multivec support.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vechord/client.py | Added create_multivec_index() and query_multivec() methods for multivec. |
| vechord/registry.py | Integrated multivec index creation and search into registry registration and querying. |
| tests/test_table.py | Added Sentence table and tests for multivec search functionality. |
| vechord/spec.py | Added a multivec_column() class method to identify multivec columns. |
| README.md | Updated features list to include multivec and hybrid search. |
| tests/test_spec.py | Expanded tests for multivec and keyword column extraction. |
| docs/source/api.md | Updated API docs to list Keyword as a public member. |
Member
Author
|
The test needs the latest vchord to support maxsim. |
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces support for multivec maxsim by adding multivec index creation and a new search_by_multivec method, updates tests and documentation, and makes minor adjustments to workflows and code style.
- Added multivec index support in the client and registry
- Updated tests to cover multivec queries and limit functionality in select_by
- Revised README badges and API documentation to reflect new features
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/simple.py | Adds a simple example demonstrating multivec search support |
| README.md | Updates assets and feature list |
| vechord/client.py | Implements create_multivec_index and updates select and query |
| tests/test_table.py | Adds tests for multivec maxsim and pipeline functionality |
| vechord/registry.py | Updates select_by to accept a limit parameter and adds search_by_multivec |
| .github/workflows/check.yml | Updates workflow configuration with additional paths and image |
| vechord/spec.py | Adds multivec_column classmethod and updates todict implementation |
| tests/test_spec.py | Extends tests to verify new multivec and keyword column support |
| .github/workflows/pages.yml | Adjusts workflow steps for docs and removes unnecessary setup |
| vechord/service.py | Updates route documentation comments for web app endpoints |
| examples/web.py | Adds a comment regarding the pipeline usage in the web app |
| examples/hybrid.py | Updates embedding to GeminiDenseEmbedding and adjusts vector size |
| docs/source/api.md | Updates API docs to include Keyword in the module members |
Signed-off-by: Keming <kemingyang@tensorchord.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @xieydd