[wip] - support for shorting#450
Open
ddragosd wants to merge 9 commits intotensortrade-org:masterfrom
Open
Conversation
|
Great Job! |
Author
|
I'm still testing this in production for a little longer before removing the |
Collaborator
|
Thanks a lot for your effort! |
Author
|
@BarakBa1 thanks for referencing the extension. Are you suggesting we don't merge this PR and instead use the extension you referenced ? |
|
Hope the shorting can be merged into the master |
|
Thanks for the efforts, hope it gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening a PR to get feedback on adding support for shorting.
I need this feature, and I'd like to share it with the community too.
Details
The implementation intentionally keeps the original behavior in place as much as possible - which is no shorting support . Developers have to be specific in the code to enable it.
What this PR adds:
MarginWallet- a class that should be explicitly used when shorting is needed. Instead of initializing aWalletinstance, developers can initialize aMarginWalletNegativeQuantity- I created this class as the current implementation is pretty strict with throwing errors for negative quantities, and I wanted to leave that functionality untouched.TODO:
Related Issues