Add more underlines#120
Conversation
adsr
left a comment
There was a problem hiding this comment.
Thank you @data-man. This looks good to me as long as these no-op on unsupported terminals instead of breaking things. I tested in xterm (not supported but doesn't break), the Linux console (same), and vte (works).
It would be a good exercise to go through popular terminal emulators to get a better sense of what else we're missing if anything. I'll leave this open to see if anyone else has comments.
This also reminds me I have a feature branch for user-defined style attributes that use the upper 32 bits of the fg and bg. I'll post a PR. Basically, if a high bit is set, termbox will ignore all the bits above and including TB_STRIKEOUT and instead invoke a callback. This gives the caller 31 bits to play with. It would give us an escape hatch for supporting anything we might miss, so long as it can be expressed in 31 bits. It would be a clean way of handling issue #107 for example.
b784c8e to
909edb9
Compare
https://en.wikipedia.org/wiki/ANSI_escape_code#Select_Graphic_Rendition_parameters For example:
At least, 58 and 59 also implemented in Contour, Konsole and WezTerm.
73 and 74 also implemented in WezTerm. |
Alacritty, foot and kitty support these, although |
My most desired feature: support https://sw.kovidgoyal.net/kitty/keyboard-protocol. In addition to kitty, this protocol is also implemented in:
Libraries implementing this protocol:
|



Many modern terminal emulators support them.
For example, WezTerm.
The small test: