feat: Adding support for regional nat gateway#1270
feat: Adding support for regional nat gateway#1270Balvinder-1995 wants to merge 8 commits intoterraform-aws-modules:masterfrom
Conversation
|
@antonbabenko @bryantbiggs can you please help review this PR to add support for regional NAT gateway. |
|
@antonbabenko / @bryantbiggs : any update on this? |
|
Hi, really looking forward to have this merged. Thanks a lot for all your work. There is just one thing I would like to mention: The docu states:
Based on my understanding of this feature, this can be misleading. See:
To my understanding this makes the pricing comparable to a classic NAT GW with the same amount of AZs configured. |
|
Hi! Just bumping this and see if it could be merged? Thank you! |
|
@Balvinder-1995 Did you test how the changes affect moving from a normal zonal NAT Gateway deployment in 2 azs with the version 6.6.0 to your changes with a regional NAT gateway in this 2 scenarios? I think it would be great to look how those 2 terraform plans look like to understand better the impact. Also, is the intention to let the normal deployment to always use ZNATs instead of RNATs? ( I see the default variable is set as availability_mode = null but I'm asking because maybe we need to also update the other examples to have consistency) |
Description
Adding support for regional NAT Gateway which is introduced in aws provider version 6.24.0
Motivation and Context
Fixes: #1269
Breaking Changes
No breaking changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request