fix: Updating AZ regex condition to support EU Sovereign Cloud AZ IDs.#1279
Open
kgoutham93 wants to merge 1 commit intoterraform-aws-modules:masterfrom
Open
fix: Updating AZ regex condition to support EU Sovereign Cloud AZ IDs.#1279kgoutham93 wants to merge 1 commit intoterraform-aws-modules:masterfrom
kgoutham93 wants to merge 1 commit intoterraform-aws-modules:masterfrom
Conversation
… az has 2 parts after splitting with hyphen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AWS EU Sovereign cloud has different conventions for zone name and zone ids. Instead of asserting the regex on entire AZ id or AZ name, we resort to a simple logic -- split the az by hypen (
-), iflength(splits) == 2we assume its AZ id.Motivation and Context
AWS EUSC has different naming conventions for AZ name and id.
Breaking Changes
None, I can think off.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsI executed examples/simple for
us-east-1andeusc-de-east-1by passing a mix of AZ names and AZ ids toazslist.pre-commit run -aon my pull request