Skip to content

feat: Support for GKE private clusters without default node pool #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ciroclover
Copy link

Fixes #2407

The diff shows a massive difference due to the "dynamic" block indentation.

The changes are:

  • Ensure that we define the initial_node_count when is not defined in the node-pool [ref].
  • Make the node-pool block dynamic. Add the conditional to ensure that the block is not generated when node_pools = [] [ref]
  • Fix the cluster_name variables in the main.tf. I honestly believe that we could just use cluster_name_computed = var.name, however, more tests should be needed. [ref]

@ciroclover ciroclover requested review from apeabody, ericyz and a team as code owners August 15, 2025 19:26
Copy link

google-cla bot commented Aug 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@m0ps
Copy link
Contributor

m0ps commented Aug 18, 2025

@ciroclover, I think, in such an arrangement, it would never be accepted. First of all, you have to use autogen to generate all submodules automatically. Also, don't forget to generate docs and perform proper linting... I would recommend you make yourself familiar with the contribution guide

@ciroclover ciroclover force-pushed the private-cluster-node-pool branch from 390dcc1 to d985e40 Compare August 20, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for GKE clusters with no default node pools
2 participants